Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 322 #123

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Feature/issue 322 #123

merged 7 commits into from
Nov 5, 2021

Conversation

Nizernizer
Copy link
Contributor

No description provided.

@Nizernizer
Copy link
Contributor Author

Nizernizer commented Nov 3, 2021 •
edited
Loading

Do not merge branches until the openapi code pushes them. @exexute

exexute
exexute reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@exexute exexute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why projectVersion is AUTO_CREATE_PROJECT_VERSION?
  2. Is the design of the RESPONSE_BODY_LENGTH_DEFAULT value unreasonable?

@Nizernizer
Copy link
Contributor Author

  1. Why projectVersion is AUTO_CREATE_PROJECT_VERSION?
  2. Is the design of the RESPONSE_BODY_LENGTH_DEFAULT value unreasonable?

Fixed and texted. Please review. @exexute

exexute
exexute approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@exexute exexute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the code.

@exexute exexute merged commit dcbffc1 into HXSecurity:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exexute exexute exexute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nizernizer @exexute