Merge pull request #1181 from Bidaya0/fix/typing-in-config_settings

fix: typing in config_settings.

dongtai_web/threshold/config_setting.py

@@ -37,6 +37,8 @@
 from dongtai_web.utils import extend_schema_with_envcheck, get_response_serializer
 from dongtai_web.serializers.agent_config import AgentConfigSettingSerializer
 from rest_framework.serializers import ValidationError
+from rest_framework.utils.serializer_helpers import ReturnDict
+from typing import Dict
 
 _ResponseSerializer = get_response_serializer(status_msg_keypair=(
     ((201, _('The setting is complete')), ''),
@@ -219,7 +221,8 @@ def get_targets(targets):
     return res
 
 
-def get_data_from_dict_by_key(dic: dict, fields: Iterable) -> dict:
+def get_data_from_dict_by_key(dic: ReturnDict | Dict,
+                              fields: Iterable) -> Dict:
     return {i: dic[i] for i in fields}
 
 

dongtai_web/threshold/tests.py

@@ -0,0 +1,18 @@
+from django.test import TestCase
+from dongtai_web.threshold.config_setting import (
+    get_data_from_dict_by_key,
+    AgentConfigSettingV2TargetSerializer,
+)
+from rest_framework.utils.serializer_helpers import ReturnDict
+
+class TypingTestCase(TestCase):
+
+    def test_typing_in_get_data_from_dict_by_key(self, ):
+        get_data_from_dict_by_key({"213123132": "123123132"}, ("213123132", ))
+        ser = AgentConfigSettingV2TargetSerializer(data={
+            "target_type": 1,
+            "opt": 1,
+            "value": "21313"
+        })
+        ser.is_valid()
+        get_data_from_dict_by_key(ser.data, ("target_type", "opt", "value"))