Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enzyme deprecation linter #4563

Closed
wants to merge 10 commits into from
Closed

Add Enzyme deprecation linter #4563

wants to merge 10 commits into from

Conversation

martijnrusschen
Copy link
Member

No description provided.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 4
- 0

75% Other
25% JSON

Generated lines of change

+ 32
- 0

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.
1 Message
📚 It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is pretty straightforward, and is just adding a linter to notify users that enzyme has been deprecated, as was discussed in the recent PR #4553.

Thanks for adding this!

Image of Ryan Ryan


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me and added enzyme deprecation lint check

Image of Xiaoyong W Xiaoyong W


Reviewed with ❤️ by PullRequest

.eslintrc Outdated Show resolved Hide resolved
@martijnrusschen
Copy link
Member Author

Before merging 156 occurences

@martijnrusschen
Copy link
Member Author

Current status 121 matches

@martijnrusschen
Copy link
Member Author

Current status 65 matches

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4563 up until the latest commit (0cb0e20). No further issues were found.

Reviewed by:

Image of Xiaoyong W Xiaoyong W

@martijnrusschen
Copy link
Member Author

Current status 52 matches

@martijnrusschen
Copy link
Member Author

34 offending lines

@martijnrusschen
Copy link
Member Author

31 offending lines

@martijnrusschen
Copy link
Member Author

23 offending lines

@martijnrusschen
Copy link
Member Author

Just 4 offending lines left!

@martijnrusschen
Copy link
Member Author

Enzyme is gone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant