Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

RUN-5674 | BrowserView creates multiply window/close events #2 #985

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

RUN-5674 | BrowserView creates multiply window/close events #2 #985

wants to merge 6 commits into from

Conversation

tomer-openfin
Copy link
Contributor

Description of Change

extending previous PR for this issue by refactoring the logic and adding .isDestroyed check.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title starts with the JIRA ticket pull request process
  • PR has assigned reviewers

@openfin-github-bot
Copy link

⚠️ Failed to build 2bbacb8

@openfin-github-bot openfin-github-bot bot added the auto testing failed Bot failed to build label Oct 7, 2019
@openfin-github-bot openfin-github-bot bot added auto testing started Bot started automated testing and removed auto testing failed Bot failed to build labels Oct 7, 2019
@openfin-github-bot
Copy link

221a889

Git

  • core: develop <= bv_fix (221a889)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 7, 2019
@MichaelMCoates
Copy link
Contributor

Got a conflict

@openfin-github-bot openfin-github-bot bot added auto testing started Bot started automated testing and removed auto testing done Bot completed automated testing labels Oct 10, 2019
@openfin-github-bot
Copy link

5b935f8

Git

  • core: develop <= bv_fix (5b935f8)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 10, 2019
@MichaelMCoates
Copy link
Contributor

This will likely conflict with #976, so may want to wait for that to go in first?

rdepena
rdepena previously approved these changes Oct 16, 2019
View reviewed changes
@tomer-openfin
Copy link
Contributor Author

@MichaelMCoates I don't mind waiting.

@openfin-github-bot openfin-github-bot bot added auto testing started Bot started automated testing and removed auto testing done Bot completed automated testing labels Oct 17, 2019
@openfin-github-bot
Copy link

de2fa83

Git

  • core: develop <= bv_fix (de2fa83)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@licui3936 licui3936 licui3936 left review comments

@rdepena rdepena rdepena left review comments

@pbaize pbaize Awaiting requested review from pbaize

@MichaelMCoates MichaelMCoates Awaiting requested review from MichaelMCoates

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
auto testing done Bot completed automated testing cla-present
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomer-openfin @MichaelMCoates @rdepena @licui3936 @finos-admin