Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

[N/A] Refresh system.js switch to named exports #996

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

pbaize
Copy link
Contributor

@pbaize pbaize commented Oct 11, 2019

Description of Change

Switches to named exports to improve dev experience. Keeping a single large export to not need changes to other files.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • automated tests are changed or added
  • manual tests are changed or added
  • relevant documentation is changed or added
  • PR title starts with the JIRA ticket pull request process
  • PR release notes describe the change in a way relevant to app-developers
  • Link to new tests added
  • PR has assigned reviewers

Release Notes

Notes:

@openfin-github-bot
Copy link

⚠️ Failed to build a1336bc

@openfin-github-bot openfin-github-bot bot added the auto testing failed Bot failed to build label Oct 11, 2019
@openfin-github-bot openfin-github-bot bot added auto testing started Bot started automated testing and removed auto testing failed Bot failed to build labels Oct 11, 2019
@openfin-github-bot
Copy link

7540eab

Git

  • core: develop <= system-refresh-1 (7540eab)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 11, 2019
@MichaelMCoates
Copy link
Contributor

got a conflict.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto testing done Bot completed automated testing cla-present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants