Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

[RUN-5718] Views can only be attached to in-app windows #999

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[RUN-5718] Views can only be attached to in-app windows #999

wants to merge 2 commits into from

Conversation

pbaize
Copy link
Contributor

@pbaize pbaize commented Oct 16, 2019

Description of Change

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • automated tests are changed or added
  • manual tests are changed or added
  • relevant documentation is changed or added
  • PR title starts with the JIRA ticket pull request process
  • PR release notes describe the change in a way relevant to app-developers
  • Link to new tests added
  • PR has assigned reviewers

Release Notes

Notes:

@openfin-github-bot openfin-github-bot bot added the auto testing started Bot started automated testing label Oct 16, 2019
@openfin-github-bot
Copy link

fdab52d

Git

  • core: develop <= RUN-5718 (fdab52d)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 16, 2019
dhamberlin
dhamberlin approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@dhamberlin dhamberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhamberlin dhamberlin dhamberlin approved these changes

@rdepena rdepena Awaiting requested review from rdepena

@MichaelMCoates MichaelMCoates Awaiting requested review from MichaelMCoates

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
auto testing done Bot completed automated testing cla-present
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbaize @dhamberlin @finos-admin