change event engine endpoing read/write return type

HannahShiSFB · Feb 27, 2023 · 88a945b · 88a945b
1 parent 402c88d
commit 88a945b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/core/BUILD b/src/core/BUILD
@@ -2066,6 +2066,7 @@ grpc_cc_library(
         "lib/event_engine/cf_engine/cfstream_endpoint.h",
         "lib/event_engine/cf_engine/cftype_unique_ref.h",
     ],
+    defines = ["GRPC_CFSTREAM=1"],
     external_deps = ["absl/strings:str_format"],
     deps = [
         "event_engine_common",

diff --git a/src/core/lib/event_engine/cf_engine/cfstream_endpoint.cc b/src/core/lib/event_engine/cf_engine/cfstream_endpoint.cc
@@ -227,7 +227,7 @@ CFStreamEndpoint::~CFStreamEndpoint() {
   write_event_.DestroyEvent();
 }
 
-void CFStreamEndpoint::Read(absl::AnyInvocable<void(absl::Status)> on_read,
+bool CFStreamEndpoint::Read(absl::AnyInvocable<void(absl::Status)> on_read,
                             SliceBuffer* buffer, const ReadArgs* /* args */) {
   read_event_.NotifyOn(new PosixEngineClosure(
       [this, on_read = std::move(on_read),
@@ -239,6 +239,8 @@ void CFStreamEndpoint::Read(absl::AnyInvocable<void(absl::Status)> on_read,
         }
       },
       false /* is_permanent*/));
+
+  return false;
 }
 
 void CFStreamEndpoint::DoRead(absl::AnyInvocable<void(absl::Status)> on_read,
@@ -277,7 +279,7 @@ void CFStreamEndpoint::DoRead(absl::AnyInvocable<void(absl::Status)> on_read,
   on_read(absl::OkStatus());
 }
 
-void CFStreamEndpoint::Write(absl::AnyInvocable<void(absl::Status)> on_writable,
+bool CFStreamEndpoint::Write(absl::AnyInvocable<void(absl::Status)> on_writable,
                              SliceBuffer* data, const WriteArgs* /* args */) {
   write_event_.NotifyOn(new PosixEngineClosure(
       [this, on_writable = std::move(on_writable),
@@ -289,6 +291,8 @@ void CFStreamEndpoint::Write(absl::AnyInvocable<void(absl::Status)> on_writable,
         }
       },
       false /* is_permanent*/));
+
+  return false;
 }
 
 void CFStreamEndpoint::DoWrite(

diff --git a/src/core/lib/event_engine/cf_engine/cfstream_endpoint.h b/src/core/lib/event_engine/cf_engine/cfstream_endpoint.h
@@ -39,9 +39,9 @@ class CFStreamEndpoint : public EventEngine::Endpoint {
                    MemoryAllocator memory_allocator);
   ~CFStreamEndpoint() override;
 
-  void Read(absl::AnyInvocable<void(absl::Status)> on_read, SliceBuffer* buffer,
+  bool Read(absl::AnyInvocable<void(absl::Status)> on_read, SliceBuffer* buffer,
             const ReadArgs* args) override;
-  void Write(absl::AnyInvocable<void(absl::Status)> on_writable,
+  bool Write(absl::AnyInvocable<void(absl::Status)> on_writable,
              SliceBuffer* data, const WriteArgs* args) override;
 
   const EventEngine::ResolvedAddress& GetPeerAddress() const override {