Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RelaxedPrecision in DXBC #939

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Support RelaxedPrecision in DXBC #939

wants to merge 6 commits into from

Conversation

HansKristian-Work
Copy link
Owner

Emits tons of RelaxedPrecision now in Hellblade FSR implementation. Untested if it helps performance in any meaningful way.

@daniel-schuermann
Copy link

misses decoration on

  • fabs
  • fmin, fmax
  • fsat
  • fma

basically all OpExtInst if I see correctly.

@HansKristian-Work
vkd3d-shader: Parse minprecision modifier.
fee77ef 
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
@HansKristian-Work
vkd3d-shader: Emit RelaxedPrecision when appropriate.
5273fbe 
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
@HansKristian-Work
vkd3d: Expose 16-bit min precision support.
34d23c9 
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
@HansKristian-Work
vkd3d-shader: Emit RelaxedPrecision for saturation modifier.
6224e1d 
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
@HansKristian-Work
vkd3d-shader: Remove fixme warning for minimum precision.
e426151 
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
@HansKristian-Work
tests: Add simple minprecision test.
cfaf310 
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
@HansKristian-Work
Copy link
Owner Author

misses decoration on

* fabs

* fmin, fmax

* fsat

* fma

basically all OpExtInst if I see correctly.

I think all of those should be covered.

@HansKristian-Work HansKristian-Work marked this pull request as ready for review May 30, 2022 10:15
@yunbiaolin
Copy link

Emits tons of RelaxedPrecision now in Hellblade FSR implementation. Untested if it helps performance in any meaningful way.

@HansKristian-Work does it benefit performance improvement for DX12 game?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitsujin doitsujin Awaiting requested review from doitsujin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HansKristian-Work @daniel-schuermann @yunbiaolin