Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator-specific context #11471

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Add generator-specific context #11471

wants to merge 3 commits into from

Conversation

Simn
Copy link
Member

@Simn Simn commented Jan 8, 2024

This PR adds a lightweight version of Common.context which holds all the data generators need. For now it's only implemented for genjvm, but should be relatively easy to add to other generators.

The main goal is to make my dependency dot graphs look nicer.

Before:

gctx before

After:

gctx after

@Simn
Copy link
Member Author

Simn commented Jan 8, 2024

I have also already "ported" our second best generator genhl, which was easy enough.

Before:

genhl before

After:

genhl after

Unlike in some other areas, smaller is better.

@skial skial mentioned this pull request Jan 9, 2024
1 task
# Conflicts:
#	src/core/stringHelper.ml
#	src/generators/genhl.ml
#	src/generators/genjvm.ml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant