Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Stop master releases using existing version numbers #1119

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented Jun 25, 2024

The counter the CI release logic uses was reset when I moved the yml to a different workflow file so the last two master commits have overwritten previous github releases... I've worked around it in this by just adding a number larger than the latest pre-github CI merge.
As mentioned in the block comment, this will need to be looked at again when we want anything other than the last build number to increase.

@Simn

@Aidan63 Aidan63 changed the title CI - Stop master releases getting overwritten. CI - Stop master releases using the same number Jun 25, 2024
@Aidan63
Copy link
Contributor Author

Aidan63 commented Jun 25, 2024

Update: Seems like it will fail instead of overwrite when it uses the same version number, which is good.

@Aidan63 Aidan63 changed the title CI - Stop master releases using the same number CI - Stop master releases using existing version numbers Jun 25, 2024
@Simn Simn merged commit d4e8d40 into HaxeFoundation:master Jun 26, 2024
100 checks passed
@Aidan63 Aidan63 deleted the ci-number-workaround branch June 26, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants