Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #871 (and unblocks HaxeFoundation/haxe#7422).
I mostly followed the implementation of
iterator
for Arrays. Some things that I am not sure about:include/hx/Object.h
has aclsIdArrayIterator
- should there ba aclsIdArrayKeyValueIterator
? I couldn't figure out what theseclsId
things actually do. For now the KV iterator is also marked asclsIdArrayIterator
.src/cppia/Cppia.h
, line 116 - I addedafKeyValueIterator
to the array functions right after the existingafIterator
. Is there an external dependency on the exact order of these values?src/cppia/ArrayBuiltin.cpp
, line 1697 - is the conversion todestType
there just "convert to object"?include/Array.h
andsrc/Array.cpp
- I added ahx::ArrayKeyValueIterator
class to mirror thehx::ArrayIterator
one. I could not define theDynamic next()
method in the header file because I cannot includeAnon.h
inArray.h
(cyclic dependency). The implementation of is insrc/Array.cpp
.The CI failure seems to be related to the last point. I guess
src/Array.cpp
(or its object file) is not being linked wherever things fromsrc/Array.h
are used?