FEAT: Adding pricing history for instrument #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding candlestick object
|
I have just noticed a mistake in the ticker that i used for testing, I will fix it and push |
|
Hi, great work, i Will review and merge asap. |
|
Hi I have added some examples and documentation. One question about the html files that you are pushing to github pages, are these generated by a package ? I can update them manually but am just wondering if they are genreated by soemthing ? |
|
Thanks. I Will review It and merge asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding get pricing history for instrument("Company")
adding candlestick object