[Feature] Option: Add games as Non-Steam Game

[Nocccer]

This PR implements the feature to add epic/gog games as non-steam games to steam.
It uses the --no-gui parameter and the protocol which heroic provides.

To adapt steams shortcuts.vdf steam-shortcut-editor thirdparty library, was used.

• Create a backend function which adds a game to the shortcuts.vdf, so steam picks it up has non-steam game
• Create a function to remove a game from the shortcuts.vdf
• Create a function to download/add/remove extra images for steam
  • uses streamgriddb and as fallback the stored images in gameInfo
• Handle flatpak and none flatpak
• Wrote types for steam-shortcut-editor
• Wrote backend tests
• Fixed gog games not launching via protocol (@imLinguin )
• Added option to specify path to steam

Known Issues:

• Steam uses glibc 2.34, which let's heroic fail on systems with newer glibc library (like glibc 2.35).
  • --no-sandbox flag is added to all shortcuts to get around this. Can be maybe added optional if system and steam glibc does not match
• Legendary can't get the locale enviroment variable inside steam and defaults to en_US. Launch will fail if the epic username uses special characters like (ö, ü, ä, ...). No Workaround yet.

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[CommandMC]

This is very nitpicky and I'm sorry, but it's "Non-Steam game", not "None-Steam game"

[CommandMC]

Will give it a test on Win and Mac in a bit (provided Steam runs on my VMs)

[Nocccer]

Okay, got it. I kind of prefer the images from Epic as well, for consistency.

And I agree, if the user had to provide their API keys, it would clutter the UI. We may consider implement this as a feature in the future, if users ask for it.

@arielj got it to work. Images are now blurred at the side.

[flavioislima]

Pretty good stuff! ⚔️

[felipecrs]

The right one is from Steam, the left one is the one from GOG added through Heroic. Astonishing, this is such a nice feature!

[felipecrs]

@Nocccer I'm trying this out on Ubuntu 22.04, with Steam installed through .deb (because the Flatpak version warns about lack of steam-devices), and while Heroic says it added to Steam, it does not appear on Steam.

After some investigation, it seems that the correct dir is:

/home/felipecrs/.steam/debian-installation/userdata/<my-id>/config

Which I think Heroic isn't looking on.

[Nocccer]

@Nocccer I'm trying this out on Ubuntu 22.04, with Steam installed through .deb (because the Flatpak version warns about lack of steam-devices), and while Heroic says it added to Steam, it does not appear on Steam.

After some investigation, it seems that the correct dir is:

/home/felipecrs/.steam/debian-installation/userdata/<my-id>/config

Which I think Heroic isn't looking on.

You can set the folder in general settings > others if i remember correctly. But add to steam should complain if no game could be added (steam folder is not available). Btw did you restart steam?

[felipecrs]

Ok... I'm just not sure what I should write there. I tried /home/felipecrs/.steam/debian-installation and it didn't work.

[felipecrs]

Ok, the issue is, no matter what I set in the Steam path, it always revert to how it was before (i.e. my setting does not apply).

[felipecrs]

Editing the config.json manually worked for me. I wrote:

/home/felipecrs/.steam/debian-installation

[Nocccer]

Ok, the issue is, no matter what I set in the Steam path, it always revert to how it was before (i.e. my setting does not apply).

ok will fix this. But actually i think the default path is correct, because on Pop_OS! it is also this path /home/niklas/.steam/steam/userdata

[felipecrs]

But I would advise you to check this folder as well. It is probably the most common folder where Steam could be found, considering that Ubuntu is one of the main used distros over there.

[felipecrs]

Ok, the issue is, no matter what I set in the Steam path, it always revert to how it was before (i.e. my setting does not apply).

ok will fix this. But actually i think the default path is correct, because on Pop_OS! it is also this path /home/niklas/.steam/steam/userdata

For me this is what was in the config.json:

/home/felipecrs/.var/app/com.valvesoftware.Steam/.steam/steam

Could it be because I previously had the Steam Flatpak installed? Perhaps the Steam install dir should be re-evaluated on every start?

[Nocccer]

But I would advise you to check this folder as well. It is probably the most common folder where Steam could be found, considering that Ubuntu is one of the main used distros over there.

POP_OS is based on ubuntu. And if you press on debian-installation it is just a shortcut to /home/niklas/.steam/steam

[Nocccer]

Ok, the issue is, no matter what I set in the Steam path, it always revert to how it was before (i.e. my setting does not apply).

ok will fix this. But actually i think the default path is correct, because on Pop_OS! it is also this path /home/niklas/.steam/steam/userdata

For me this is what was in the config.json:

/home/felipecrs/.var/app/com.valvesoftware.Steam/.steam/steam

Could it be because I previously had the Steam Flatpak installed? Perhaps the Steam install dir should be re-evaluated on every start?

delete steam flatpak if you don't want to use it. Else add-to-steam will add it to steam flatpak.

[felipecrs]

For me it does not seem to be a shortcut:

 ls -la .steam
total 24
drwxrwxr-x  3 felipecrs felipecrs 4096 jul 21 13:55 .
drwxr-x--- 33 felipecrs felipecrs 4096 jul 21 13:58 ..
lrwxrwxrwx  1 felipecrs felipecrs   28 jul 21 13:55 bin -> /home/felipecrs/.steam/bin32
lrwxrwxrwx  1 felipecrs felipecrs   54 jul 21 13:55 bin32 -> /home/felipecrs/.steam/debian-installation/ubuntu12_32
lrwxrwxrwx  1 felipecrs felipecrs   54 jul 21 13:55 bin64 -> /home/felipecrs/.steam/debian-installation/ubuntu12_64
drwxrwxr-x 26 felipecrs felipecrs 4096 jul 21 13:57 debian-installation
-rwxrwxr-x  1 felipecrs felipecrs 1149 jul 21 13:55 registry.vdf
lrwxrwxrwx  1 felipecrs felipecrs   42 jul 21 13:55 root -> /home/felipecrs/.steam/debian-installation
lrwxrwxrwx  1 felipecrs felipecrs   50 jul 21 13:55 sdk32 -> /home/felipecrs/.steam/debian-installation/linux32
lrwxrwxrwx  1 felipecrs felipecrs   50 jul 21 13:55 sdk64 -> /home/felipecrs/.steam/debian-installation/linux64
lrwxrwxrwx  1 felipecrs felipecrs   42 jul 21 13:55 steam -> /home/felipecrs/.steam/debian-installation
-rw-rw-r--  1 felipecrs felipecrs    6 jul 21 13:55 steam.pid
prw-------  1 felipecrs felipecrs    0 jul 21 13:54 steam.pipe
-r--------  1 felipecrs felipecrs   16 jul 21 13:55 steam.token

I think PopOS packages their own Steam deb.

[felipecrs]

delete steam flatpak if you don't want to use it. Else add-to-steam will add it to steam flatpak.

Of course I did it... still, Heroic was looking on .var.

[Nocccer]

Please first delete steam-flatpak and his folders. There are folders in .var left still for steam flatpak.

[felipecrs]

Got it. I didn't delete the folder indeed.

[Nocccer]

Got it. I didn't delete the folder indeed.

Note the default path should work. Because i assume Ubuntu - steam is different then Pop_OS - steam installation

[felipecrs]

Ok, I confirmed that /home/felipecrs/.steam/steam also works.

But I had to write it manually in the config.json, even after deleting the Flatpak folder in .var.

[Nocccer]

Ok, I confirmed that /home/felipecrs/.steam/steam also works.

But I had to write it manually in the config.json, even after deleting the Flatpak folder in .var.

Btw better create a github issue instead writing here on a closed pr.