Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix livecheck of bilibili #175463

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Conversation

Aaron-212
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Related to #171006

Signed-off-by: Aaron-212 <aaron212cn@outlook.com>
Casks/b/bilibili.rb Outdated Show resolved Hide resolved
Casks/b/bilibili.rb Outdated Show resolved Hide resolved
Casks/b/bilibili.rb Outdated Show resolved Hide resolved
@miccal miccal added the awaiting user reply Issue needs response from a user. label May 31, 2024
@miccal miccal merged commit 05bfa43 into Homebrew:master Jun 2, 2024
9 checks passed
@Aaron-212 Aaron-212 deleted the fix-bilibli-livecheck branch June 3, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting user reply Issue needs response from a user.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants