Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite dbhash sqldiff sqlite-analyzer 3.39.0 #104489

Closed
wants to merge 4 commits into from

Conversation

owine
Copy link
Sponsor Contributor

@owine owine commented Jun 26, 2022

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Jun 26, 2022
@owine owine changed the title sqlite 3.39.0 sqlite dbhash sqldiff sqlite-analyzer 3.39.0 Jun 26, 2022
@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Jun 27, 2022
@danielnachun
Copy link
Member

This is failing only because of python@3.7. Is it time to deprecate it? It only has two dependents both of which are deprecated.

@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jun 27, 2022
@cho-m
Copy link
Member

cho-m commented Jun 28, 2022

This is failing only because of python@3.7. Is it time to deprecate it? It only has two dependents both of which are deprecated.

From EOL standpoint, python@3.7 is supported until June 2023.

However, I think the problem here is that importlib-metadata has a setup_requires dependency on setuptools_scm, but setuptools_scm>=7 has a runtime dependency on importlib-metadata. It picks up the vendor copy within setuptools and fails.

Upstream has specifically mentioned they consider Homebrew's way of handling package installation unsupported (pypa/setuptools-scm#722 (comment)).

We luckily got a fix for Python 3.8 and later as importlib-metadata is only needed on Python 3.7, but it is possible that we will hit more of these issues in future. For example, we see a build loop in jupyterlab #104097.


If we want to keep python@3.7, then one option is to locally inreplace importlib-metadata/setup.cfg to restrict setuptools_scm[toml] requirement to < 7.

If we want to deprecate, we could use :unsupported reason as that is pretty much what upstream told us.

@carlocab
Copy link
Member

I suggest doing inreplace. Possibly also consider deprecating it, but I think that's just going to end up teaching users not to take deprecation warnings seriously.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 1, 2022
@owine
Copy link
Sponsor Contributor Author

owine commented Jul 2, 2022

This is blocked by python@3.7

@github-actions github-actions bot removed the stale No recent activity label Jul 2, 2022
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Jul 2, 2022
@carlocab
Copy link
Member

carlocab commented Jul 7, 2022

This is blocked by python@3.7

Actually, it's not. brew install python@3.7 fails with the same error even without this PR. (Which makes sense, because the failure looks to be happening inside pure Python code rather than in anything sqlite-related.)

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab mentioned this pull request Jul 7, 2022
@owine owine deleted the bump-sqlite-3.39.0 branch July 7, 2022 14:00
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. in progress Stale bot should stay away long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants