rustfmt 1.5.2

[Porkepix]

Created by brew bump

---

Created with brew bump-formula-pr.

[chenrui333]

  ==> rustfmt --check ./src/main.rs
  dyld[81216]: Library not loaded: '@rpath/librustc_driver-f64ac9ee9a3f0eb4.dylib'
    Referenced from: '/opt/homebrew/Cellar/rustfmt/1.5.2/bin/rustfmt'
    Reason: tried: '/usr/local/lib/librustc_driver-f64ac9ee9a3f0eb4.dylib' (no such file), '/usr/lib/librustc_driver-f64ac9ee9a3f0eb4.dylib' (no such file)

[SMillerDev]

Is this an issue with rustup usage?

[carlocab]

Is this an issue with rustup usage?

Most likely, yes. We're using a pretty old nightly to build this, though. Maybe the rust formula works now? It may be a runtime dep.

[chenrui333]

Is this an issue with rustup usage?

Most likely, yes. We're using a pretty old nightly to build this, though. Maybe the rust formula works now? It may be a runtime dep.

yeah, it depends on a nightly build, I tried the specified nightly build, but did not quite work out for me.
https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md?plain=1#L26-L29

[chenrui333]

the build went fine in my local, but in runtime it reference some librustc_driver

==> rustfmt --check ./src/main.rs
Last 15 lines from /Users/rui/Library/Logs/Homebrew/rustfmt/test.02.rustfmt:
2023-01-26 10:32:30 -0500

rustfmt
--check
./src/main.rs

dyld[52306]: Library not loaded: @rpath/librustc_driver-f64ac9ee9a3f0eb4.dylib
  Referenced from: <2CCD3F33-AAEE-3ADE-A78C-AC78D489E170> /opt/homebrew/Cellar/rustfmt/1.5.2/bin/rustfmt
  Reason: tried: '/System/Volumes/Preboot/Cryptexes/OS@rpath/librustc_driver-f64ac9ee9a3f0eb4.dylib' (no such file), '/usr/local/lib/librustc_driver-f64ac9ee9a3f0eb4.dylib' (no such file), '/usr/lib/librustc_driver-f64ac9ee9a3f0eb4.dylib' (no such file, not in dyld cache)
Error: rustfmt: failed

[carlocab]

I wonder if we can just read this from the rust-toolchain file so that this doesn't have to be updated manually.

[chenrui333]

that makes sense.

[branchvincent]

note rustup's cargo already reads the version from that file, so unless we want to be explicit all we need is

    system "#{Formula["rustup-init"].bin}/rustup-init", "-qy", "--no-modify-path"
    ENV.prepend_path "PATH", HOMEBREW_CACHE/"cargo_cache/bin"
    system "cargo", "install", *std_cargo_args

Example

==> cargo install --locked --root /opt/homebrew/Cellar/rustfmt/1.5.2 --path .
info: syncing channel updates for 'nightly-2023-01-24-aarch64-apple-darwin'
info: latest update on 2023-01-24, rust version 1.69.0-nightly (c8e6a9e8b 2023-01-23)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'llvm-tools'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustc-dev'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'llvm-tools'
info: installing component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustc-dev'
info: installing component 'rustfmt'
  Installing rustfmt-nightly v1.5.2 (/private/tmp/rustfmt-20230126-48518-ucx7qv/rustfmt-1.5.2)
...

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[chenrui333]

#137033