Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgraph: deprecate #79070

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

nandahkrishna
Copy link
Member

Installing dgraph on macOS is unsupported for newer versions, i.e.,
21.03.0 and newer. They suggest using Docker instead, and have removed
build instructions for macOS from their README.

See:


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@nandahkrishna nandahkrishna added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jun 10, 2021
@BrewTestBot BrewTestBot added formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue labels Jun 10, 2021
Installing `dgraph` on macOS is unsupported for newer versions, i.e.,
21.03.0 and newer. They suggest using Docker instead, and have removed
build instructions for macOS from their README.

See:
* https://dgraph.io/docs/dgraph-overview/#get-started-with-self-managed-dgraph
* dgraph-io/dgraph#7685
@nandahkrishna nandahkrishna mentioned this pull request Jun 10, 2021
@nandahkrishna nandahkrishna merged commit 7c34424 into Homebrew:master Jun 10, 2021
@nandahkrishna nandahkrishna deleted the dgraph-deprecate branch June 10, 2021 12:55
nandahkrishna added a commit to nandahkrishna/homebrew-core that referenced this pull request Jun 10, 2021
Should have included this in Homebrew#79070.
@nandahkrishna nandahkrishna mentioned this pull request Jun 10, 2021
6 tasks
nandahkrishna added a commit that referenced this pull request Jun 10, 2021
Should have included this in #79070.
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
@chenrui333
Copy link
Member

That PR seems a bit confusing, it seems never showed up in the master branch, also in the latest release, the homebrew installation is still featured, https://github.com/dgraph-io/dgraph#macos

@nandahkrishna
Copy link
Member Author

nandahkrishna commented Mar 5, 2023

@chenrui333 see here: https://github.com/dgraph-io/dgraph#supported-platforms, it says that macOS is no longer officially supported.

(Also, the README doesn't feature installation via Homebrew for dgraph itself but for just its dependencies.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants