Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmctl 6.2.0 #91184

Closed
wants to merge 3 commits into from
Closed

mmctl 6.2.0 #91184

wants to merge 3 commits into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Dec 12, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka
mmctl 6.1.0
a7e896a 
The 6.2.0 tag was deleted upstream, let's go back to 6.1.0
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Dec 12, 2021
@iMichka iMichka mentioned this pull request Dec 12, 2021
Closed
@iMichka
Copy link
Member Author

iMichka commented Dec 12, 2021

Upstream issue, looks like 6.2.0 is gone: mattermost/mmctl#417

@iMichka iMichka mentioned this pull request Dec 12, 2021
Closed
@iMichka iMichka added upstream issue An upstream issue report is needed upstream-recall-release upstream recalled the release and removed upstream issue An upstream issue report is needed do not merge labels Dec 14, 2021
@iMichka
Copy link
Member Author

iMichka commented Dec 14, 2021

Let's ship this, upstream did not respond, but the release is gone so let's go back to the previous one. This is ready to be reviewed.

@iMichka iMichka added the ready to merge PR can be merged once CI is green label Dec 14, 2021
branchvincent
branchvincent previously approved these changes Dec 15, 2021
View reviewed changes
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@chenrui333
Copy link
Member

They just made a new release, saving us a bit with version_scheme reset. 🤣

@chenrui333 chenrui333 added the checksum mismatch SHA-256 doesn't match the download label Dec 15, 2021
@chenrui333 chenrui333 changed the title mmctl 6.1.0 mmctl 6.2.0 Dec 15, 2021
@iMichka
Copy link
Member Author

iMichka commented Dec 15, 2021

What a mess. Thanks for the final update.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@branchvincent branchvincent branchvincent left review comments

Assignees
No one assigned
Labels
checksum mismatch SHA-256 doesn't match the download go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green upstream-recall-release upstream recalled the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iMichka @BrewTestBot @chenrui333 @branchvincent