Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perkeep: migrate to go #95740

Closed
wants to merge 1 commit into from
Closed

perkeep: migrate to go #95740

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 23, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Feb 23, 2022
@iMichka iMichka force-pushed the perkeep branch 2 times, most recently from eb00f73 to f0f1a50 Compare February 23, 2022 22:18
@iMichka iMichka mentioned this pull request Feb 23, 2022
@iMichka
Copy link
Member Author

iMichka commented Feb 28, 2022

Fixed by #95964

@iMichka iMichka closed this Feb 28, 2022
@iMichka iMichka deleted the perkeep branch February 28, 2022 21:32
@Bo98
Copy link
Member

Bo98 commented Feb 28, 2022

Oops didn't even notice there was a PR open, let alone was related to the Go PR. I was just going through versioned formulae to deprecate and saw a cheeky go@1.12 that didn't exist 😅

@iMichka
Copy link
Member Author

iMichka commented Feb 28, 2022

It's ok. I opened a bunch of fixes for the go PR, did not have time to fix the remaining ones. Thanks for taking care of this one.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants