HDR Lightmap Exporting #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
force-pushed
the
hdr-lightmaps
branch
from
f079b08
to
2ed3a27
Compare
netpro2k
force-pushed
the
hdr-lightmaps
branch
from
2ed3a27
to
b7b4aa9
Compare
| "backgroundColor": { "type": "color", "default": "#aaaaaa" }, | ||
| "backgroundTexture": { | ||
| "type": "texture", | ||
| "label": "Backgorund Image", |
| @@ -150,7 +153,7 @@ def gather_color_property(export_settings, blender_object, target, property_name | |||
| c = getattr(target, property_name) | |||
| return "#{0:02x}{1:02x}{2:02x}".format(max(0, min(int(c[0] * 256.0), 255)), max(0, min(int(c[1] * 256.0), 255)), max(0, min(int(c[2] * 256.0), 255))) | |||
|
|
|||
| @cached | |||
| # MOZ_lightmap extension data | |||
There was a problem hiding this comment.
Where did @cached go?
(I don't know what @cached means)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to export lightmap as RGBE .hdr lightmaps. Currently only works with images already in .hdr format (not .exr) but this should be easy to fix down the road. Note that HDR images must be saved before exporting or things will silently fail to export. There is currently not a great way to handle errors like that (see KhronosGroup/glTF-Blender-IO#1411)
This is built against the current GLTF exporter but things may change depending on discussions upstream KhronosGroup/glTF-Blender-IO#1410