Various test cleanups for Crosshair integration #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
reviewed
Aug 24, 2024
Comment on lines
+115
to
117
| if current_build_context().data.provider.avoid_realization: | ||
| pytest.skip("symbolic backends can filter efficiently!") | ||
|
|
There was a problem hiding this comment.
Should we instead hardcode a check against the crosshair backend, or only run on the hypothesis backend? avoid_realization is correlated with but not quite the same as a backend filtering efficiently.
There was a problem hiding this comment.
I'm basically assuming that "avoid_realization means symbolic execution", so while it's not the same thing I think it's likely to be the right call.
|
re: I've seen this fail with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4034 to make that smaller + easier to review again 🙂