Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Signals GMA DevApp #30

Merged
merged 15 commits into from
Apr 19, 2023
Merged

Secure Signals GMA DevApp #30

merged 15 commits into from
Apr 19, 2023

Conversation

bleege
Copy link
Contributor

@bleege bleege commented Apr 18, 2023

Creates a DevApp for the purposes of:

  • Providing a test harness for UID2 to Google GMA integration via the Secure Signals GMA Plugin.

Related Work:

iOS Version:

@bleege bleege self-assigned this Apr 18, 2023
@bleege bleege requested a review from IanDBird April 18, 2023 04:15
IanDBird
IanDBird requested changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@IanDBird IanDBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a collection of nits that we should ideally update. Also, as mentioned in the other review, for consistency it should be in a module called dev-app, not devapp.

securesignals-gma-devapp/.gitignore Outdated Show resolved Hide resolved
securesignals-gma-devapp/build.gradle Outdated Show resolved Hide resolved
securesignals-gma-devapp/build.gradle Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/java/com/uid2/dev/MyActivity.java Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/res/drawable-v24/ic_launcher_foreground.xml Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/res/mipmap-anydpi-v26/ic_launcher.xml Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml Outdated Show resolved Hide resolved
securesignals-gma-devapp/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
@bleege
Copy link
Contributor Author

bleege commented Apr 19, 2023

The requested changes have now been made. PR is ready for 👀 again.

IanDBird
IanDBird previously approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@IanDBird IanDBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bleege
Copy link
Contributor Author

bleege commented Apr 19, 2023

I've rebased on to main now that #29 has merged and caused a small conflict with settings.gradle.

@bleege bleege merged commit 753b57e into main Apr 19, 2023
@bleege bleege deleted the bwl-gma-devapp branch April 19, 2023 17:26
@bleege bleege mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanDBird IanDBird IanDBird approved these changes

Assignees

@bleege bleege

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bleege @IanDBird