Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

sketch file will not open when gutter and margin are set as vw units #13

Closed
Plummat opened this issue Jan 31, 2018 · 3 comments
Closed

sketch file will not open when gutter and margin are set as vw units #13

Plummat opened this issue Jan 31, 2018 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Plummat
Copy link

Plummat commented Jan 31, 2018

No description provided.

@seejamescode seejamescode added the good first issue Good for newcomers label Jan 31, 2018
@seejamescode
Copy link
Contributor

If anyone wants to take this on: The solution is convert all vw values in these variables. The vw values should be converted to px by doing Xvw * .01 * breakpointSizeInPX.

@Plummat
Copy link
Author

Plummat commented Jan 31, 2018 •
edited
Loading

@seejamescode on line 216, don't you simply need to pass in width to calculate the gutter, like you do when calculating margin?

@seejamescode
Copy link
Contributor

Yeah, that needs to happen for any property that could be a vw. But we also need to add an argument for parseUnit that is breakpoint width. I do not believe Sketch will take a % unit.

seejamescode added a commit that referenced this issue Mar 1, 2018
@seejamescode
Merge pull request #29 from IBM/fixes
c5c3ff2 
fix(sketch): fix #13, sketch file generated even if gutters use vw units
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Plummat @seejamescode