Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detect-secret tagging and also publish versioned UBI-images #88

Merged
merged 2 commits into from
May 10, 2022

Conversation

tefiggins
Copy link
Member

@tefiggins tefiggins commented May 10, 2022

This PR will address both powerups backlog issue 755 and 490.

  • Fix detect-secrets Docker image tagging in Makefile to include additional tags (755)

A previous PR modified the way the docker-publish-images make target worked, but it also lost the debug tagged images and some other specific tagged images that we think it needed. This PR addresses this issue.

  • Build and publish versioned images for detect-secrets:redhat-ubi and detect-secrets:redhat-ubi-custom (490)

There's currently no way for our users to pull down a specific version of the detect-secrets redhat-ubi-tagged images. This is fine for now, but when we release the next version of Detect Secrets, our users will get that most recent image version since there's no way to peg to a specific version for these images. This PR addresses this issue

Makefile.ibm Outdated Show resolved Hide resolved
Makefile.ibm Outdated Show resolved Hide resolved
@victoria-miltcheva
Copy link
Member

victoria-miltcheva commented May 10, 2022

Final question:

What does the output of the docker images command look like after running the build, publish, and deploy functions?

@tefiggins
Copy link
Member Author

image

Note: remove the "dssDegugTag" for the end of the ones in the picture. Also Note: that this would be the local docker repo of the Travis VM running the build (ie working ground)... you see one that are published and where based on the start of there name (ie the non "git-defender" starting one). Hop this is what you are asking for above.

Copy link
Member

@victoria-miltcheva victoria-miltcheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tefiggins tefiggins merged commit 43c6f57 into IBM:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants