Bug #8, fix inject_post_activity_survey_link() Javascript [iet:1033…

…4595] * Plus, Travis-CI/ eslint/ unused-vars JS fix
IET-OU · Apr 18, 2018 · 3866d7e · 3866d7e
1 parent c8ceb38
commit 3866d7e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/js/src/local-fixes.js b/js/src/local-fixes.js
@@ -13,8 +13,7 @@ module.exports = function ($, resp) {
   inject_long_texts($, resp);
   quiz_word_count($, resp);
 
-  course_add_tesla_result_links($, resp);
-
+  course_add_tesla_result_links($);
   admin_add_course_category_link($);
 
   $(window.document).ajaxSuccess(function (ev, xhr, settings) {
@@ -185,9 +184,9 @@ function fix_pilot_fallback_link($, resp) {
   // console.warn('>> ouop-pilot-fallback-link: ', $link, m_inst);
 }
 
-function course_add_tesla_result_links($, resp) {
+function course_add_tesla_result_links($) {
   var $cm_edit_menus = $('.path-course-view .section-cm-edit-actions[ data-owner ]');
-  var lti_res = resp.config.lti_results;
+  // var lti_res = resp.config.lti_results;
 
   $cm_edit_menus.each(function (idx, el) {
     var cmid = $(el).data('owner').replace(/#module-/, '');

diff --git a/js/src/survey-embed-link.js b/js/src/survey-embed-link.js
@@ -90,7 +90,8 @@ function inject_post_activity_survey_link ($, resp) {
     // var $container_quiz_rev = $('#page-mod-quiz-review #user-notifications');
     var $container_quiz = $('#page-mod-quiz-view');
     var $container_assign = $('#page-mod-assign-view');
-    var survey_url = resp.survey_urls[ resp.course_code ].post.replace('{OUCU}', resp.profile.ouop_oucu);
+    var survey_url = resp.survey_urls.post.replace('{OUCU}', resp.profile.ouop_oucu).replace('{COURSE}', resp.course_code);
+    // WAS: var survey_url = resp.survey_urls[ resp.course_code ].post.replace('{OUCU}', resp.profile.ouop_oucu);
     var util = resp.util;
 
     // $container_quiz_rev.append(util.alert(util.str('post_survey_msg', survey_url)));