Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review FieldReferenceFunction, FieldScopeFunction, SubtypeFilter #1141

Merged
merged 5 commits into from
Jan 31, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

@pvojtechovsky pvojtechovsky commented Jan 20, 2017

This PR contains FieldReferenceFunction, FieldScopeFunction, SubtypeFilter.
The main purpose is FieldReferenceFunction, which returns all the references to the field. Other two are helper classes which might be useful for others so they are public.

It depends on these PRs

The tests will be added later, because they share a lot with tests of #1136

@pvojtechovsky pvojtechovsky force-pushed the FieldReferenceFunction branch 2 times, most recently from c47f41d to 9455886 Compare January 21, 2017 06:41
@pvojtechovsky pvojtechovsky changed the title WIP Field reference function WIP FieldReferenceFunction, FieldScopeFunction, SybtypeFilter Jan 21, 2017
@pvojtechovsky pvojtechovsky changed the title WIP FieldReferenceFunction, FieldScopeFunction, SybtypeFilter WIP FieldReferenceFunction, FieldScopeFunction, SubtypeFilter Jan 22, 2017
@pvojtechovsky pvojtechovsky changed the title WIP FieldReferenceFunction, FieldScopeFunction, SubtypeFilter review FieldReferenceFunction, FieldScopeFunction, SubtypeFilter Jan 25, 2017
@pvojtechovsky
Copy link
Collaborator Author

Only this PR might need more tests, which would check package and public visible class fields in different packages.

.forEach(outputConsumer);
}
protected void searchForProtectedField(CtField<?> field, CtConsumer<Object> outputConsumer) {
//protected field can be referred from the scope of current top level type only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the scope of current top level type only

and children

@surli
Copy link
Collaborator

surli commented Jan 30, 2017

Seems good to me. I'm waiting for the new tests before merging.

@pvojtechovsky
Copy link
Collaborator Author

The tests of field visibility in other classes and packages were added. It is finished from my point of view.

@pvojtechovsky
Copy link
Collaborator Author

Looks like Travis is ill.

@surli surli merged commit 6bef9fd into INRIA:master Jan 31, 2017
@pvojtechovsky pvojtechovsky deleted the FieldReferenceFunction branch January 31, 2017 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants