chore: convert qodana config to new format

.github/workflows/qodana-cloud.yaml

@@ -0,0 +1,35 @@
+# Workflow for testing spoon code quality.
+#
+# Note that actions are specified by commit hash. This is to avoid the security
+# risk of someone injecting malicious code into a release and then simply
+# changing a tag.
+
+name: Qodana-Cloud-Scan
+on:
+  workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - master
+
+permissions:
+  contents: read
+jobs:
+  qodana:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+    steps:
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
+        with:
+          fetch-depth: 0
+      - name: 'Qodana Scan'
+        uses: JetBrains/qodana-action@77f0ff0c702065648df9fd0340a48919dca5a1ff # v2023.2.1
+        env:
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
+      - uses: github/codeql-action/upload-sarif@a09933a12a80f87b87005513f0abb1494c27a716 # v2
+        with:
+          sarif_file: ${{ runner.temp }}/qodana/results/qodana.sarif.json
+

.github/workflows/qodana.yml

@@ -22,6 +22,8 @@ jobs:
           with:
             args: --source-directory,./src/main/java , --fail-threshold, 0
             post-pr-comment: "false"
+          env:
+              QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
         - uses: github/codeql-action/upload-sarif@a09933a12a80f87b87005513f0abb1494c27a716 # v2
           with:
             sarif_file: ${{ runner.temp }}/qodana/results/qodana.sarif.json
@@ -37,6 +39,8 @@ jobs:
           with:
             args: --source-directory,./spoon-javadoc/src/main/java , --fail-threshold, 0
             post-pr-comment: "false"
+          env:
+            QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
         - uses: github/codeql-action/upload-sarif@a09933a12a80f87b87005513f0abb1494c27a716 # v2
           with:
             sarif_file: ${{ runner.temp }}/qodana/results/qodana.sarif.json

qodana.yaml

@@ -1,30 +1,39 @@
 profile:
   name: qodana.recommended
 version: "1.0"
-include:
-  - name: Anonymous2MethodRef
-  - name: AssignmentToCatchBlockParameter
-  - name: AssignmentToLambdaParameter
-  - name: AssignmentToMethodParameter
-  - name: AssignmentToNull
-  - name: Convert2Lambda
-  - name: DoubleBraceInitialization
-  - name: EqualsAndHashcode
-  - name: JavaLangImport
-  # Disabled for annotations applied to type
-  #- name: MissortedModifiers
-  - name: NestedAssignment
-  - name: NonShortCircuitBoolean
-  - name: RedundantFieldInitialization
-  - name: RedundantSuppression
-  - name: Reformat
-  - name: ReturnNull
-  - name: SamePackageImport
-  - name: StringEquality
-  - name: UnnecessaryBoxing
-  - name: UnnecessaryLocalVariable
-  - name: UnnecessaryUnboxing
-  - name: UNUSED_IMPORT
-  - name: PointlessBooleanExpression 
-exclude:
-  - name: UseOfClone
+linter: jetbrains/qodana-jvm:2023.2
+groups:
+  - groupId: IncludedPaths
+    groups:
+          - "category:Java"
+          - "GLOBAL"
+  - groupId: ExcludedInspections # list of inspections disabled by specific reason
+    inspections:
+      - "!IncludedPaths"
+      - Annotator # substituted by JavaAnnotator in sanity
+      - JavaAnnotator # works in "sanity" inspections
+      - SyntaxError # should work on sanity level
+      - Since15 # Detects wrong language level. Should work on sanity.
+      - JavadocBlankLines # Questionable. Spam on mockito, RxJava and other projects.
+      - UseOfClone # We often use clone (correctly implemented as a deep copy). It's not a problem.
+      - UnstableApiUsage  
+      - MissortedModifiers   # Disabled for annotations applied to type
+inspections:
+  - group: ExcludedInspections
+    enabled: false
+  - group: IncludedPaths
+    ignore:
+      - "vendor/**"
+      - "build/**"
+      - "buildSrc/**"
+      - "builds/**"
+      - "dist/**"
+      - "tests/**"
+      - "tools/**"
+      - "vendor/**"
+      - "**.test.ts"
+      - "scope#$gitignore" # $gitignore scope available only in qodana execution
+      - "scope#test:*..*"
+      - "scope#file:buildSrc/*"
+  - inspection: JavadocReference
+    severity: WARNING # It has default ERROR severity. It's understandable for unresolved references in javadocs for editor but not on CI.

src/main/java/spoon/support/reflect/code/CtInvocationImpl.java

@@ -207,4 +207,14 @@
 	public CtInvocation<T> clone() {
 		return (CtInvocation<T>) super.clone();
 	}
+
+
+	// just to test if qodana works
+	public void qodanaTest(String a) {
+		Integer[] arr = null;
+		arr.toString();
+		arr.hashCode();
+		a.equals(arr);
+		System.out.println(a);
+	}
 }