Solver design refactoring #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dtd-electromagnetic-solver
…dtd-electromagnetic-solver
…dtd-electromagnetic-solver
…dtd-electromagnetic-solver
…dtd-electromagnetic-solver
…dtd-electromagnetic-solver
…th new changes in master
…dtd-electromagnetic-solver
aaadelmann
requested changes
Sep 26, 2023
aaadelmann
previously approved these changes
Sep 27, 2023
matt-frey
requested changes
Sep 29, 2023
srikrrish
reviewed
Sep 29, 2023
There was a problem hiding this comment.
I like that we now separate into LinearSolvers and equation specific solvers. But is then Solver and LinearSolvers sort of confusing? Ideally instead of Solver directory there should be PoissonSolvers, MaxwellSolvers and may be in future we have NavierStokesSolvers etc. Then the files corresponding to them can be moved into the appropriate directories I think.
…sonSolver --> FFTOpenPoissonSolver
srikrrish
approved these changes
Sep 29, 2023
matt-frey
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refactor the solver according to the proposed design in the attached slides.
solver_design.pdf