Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Null Solver that has no action #252

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

s-mayani
Copy link
Collaborator

A NullSolver class inheriting from the Poisson base class is added. The NullSolver class is convenient because it allows to maintain the structure/software design of the program, requiring the user to only change the solver type to NullSolver when no solve action is wanted instead of having to code if statements. This functionality in needed in some programs such as OPAL when we seek to not have any solve action in a simulation.

@matt-frey matt-frey added the feature request Used to label a feature request in the issue tracker. label Jan 11, 2024
src/PoissonSolvers/NullSolver.h Outdated Show resolved Hide resolved
test/solver/TestNullSolver.cpp Outdated Show resolved Hide resolved
Copy link
Member

@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@s-mayani s-mayani merged commit 608e783 into IPPL-framework:dev-3.2.0 Jan 12, 2024
@s-mayani s-mayani deleted the null_solver branch January 12, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to label a feature request in the issue tracker.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants