109 - Add totalFilesCount to GetDatasetFiles use case #116
Conversation
GPortas
added
pm.GREI-d-2.7.1
There was a problem hiding this comment.
Looks good.
We need also to export the FilesSubset model in the index.ts file of the files folder, just as we do with the DatasetPreviewSubset
I addressed the change. But I'm worried about what would had happened if you hadn't noticed. I think that somehow we need some tests to test the package from the outside. To force the check on these index exports, and also ensure that the package functions properly when used as a library |
Yes. There is an open issue related to functional tests that would be useful for what you mention: #81 I just updated the issue to link to this comment. |
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| filesPayload.forEach(function (filePayload: any) { | ||
| files.push(transformFilePayloadToFile(filePayload)); | ||
| filesPayload.forEach(function (filesPayload: any) { |
There was a problem hiding this comment.
Why have you changed the name of the variable inside the function from singular to plural?
Now we have transformFilePayloadToFile(filesPayload) which makes it a little confusing.
There was a problem hiding this comment.
My bad, I committed the change to restore the name
GPortas
deleted the
feature/109-add-total-file-count-to-getdatasetfiles-use-case
branch
What this PR does / why we need it:
This PR introduces
totalFilesCountto theGetDatasetFilesuse case, which is essential for pagination. This ensures consistency with the pagination implementation, as seen inDatasetPreviewSubset.Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
The implementation should be consistent with GetAllDatasetPreviews implementation, so just compare the code with that use case
Suggestions on how to test this:
Run integration tests or review GitHub action execution