122 - Extend dataset and file models to contain owner information #127
Conversation
MellyGray
added
Size: 3
| return transformHtmlToMarkdown(metadataFieldValuePayload); | ||
| } else if (Array.isArray(metadataFieldValuePayload)) { | ||
| if (isArrayOfSubfieldValue(metadataFieldValuePayload)) { | ||
| return metadataFieldValuePayload.map((v) => transformPayloadToDatasetMetadataSubfieldValue(v)); |
There was a problem hiding this comment.
Minor detail - Can we rename "v" to something more understandable?
| const transformPayloadToDatasetMetadataFields = ( | ||
| metadataFieldsPayload: MetadataFieldPayload[], | ||
| ): DatasetMetadataFields => { | ||
| return metadataFieldsPayload.reduce((acc: DatasetMetadataFields, field: MetadataFieldPayload) => { |
There was a problem hiding this comment.
Minor detail - Can we rename "acc" to something more understandable? Like datasetMetadataFieldsResult or simply result
There was a problem hiding this comment.
I don't like result because it means finished, but the variable in this case is the accumulator so it's not really the result until the reduce it's finished, I rename it to datasetMetadataFieldsMap, hope that's ok
| @@ -0,0 +1,12 @@ | |||
| export interface DvObjectOwnerNode { | |||
There was a problem hiding this comment.
I don't think dv-object should be considered as a sub-domain in the package. I would place this file and any other dvObject related file in the core subdomain, as the dvObject is a concept shared across the different subdomains (collections, files and datasets).
…vascript into feat/122-extend-dataset-and-file-models-to-contain-owner-information
GPortas
deleted the
feat/122-extend-dataset-and-file-models-to-contain-owner-information
branch
What this PR does / why we need it:
This PR extends the payload of the dataset and file model to add a new owner property with the owner information of the object.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
I also added some types for the file and dataset payload to avoid using any.
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Dataset and file models extended to add object owner information
Additional documentation: