Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds returnDatasetVersion optional param to getFile use case #129

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Adds returnDatasetVersion optional param to getFile use case #129

merged 5 commits into from
Feb 28, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Feb 27, 2024

What this PR does / why we need it:

Adds returnDatasetVersion optional param to getFile use case

Which issue(s) this PR closes:

  • None

Suggestions on how to test this:

Visual inspection and GitHub action run check

Is there a release notes update needed for this change?:

None

@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: File Page labels Feb 27, 2024
MellyGray
MellyGray requested changes Feb 27, 2024
View reviewed changes
docs/useCases.md Outdated Show resolved Hide resolved
@GPortas GPortas removed their assignment Feb 28, 2024
@MellyGray MellyGray self-assigned this Feb 28, 2024
MellyGray
MellyGray approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MellyGray MellyGray removed their assignment Feb 28, 2024
@MellyGray MellyGray merged commit 6a0cf8a into develop Feb 28, 2024
2 checks passed
@MellyGray MellyGray deleted the get_file_return_dataset_version branch February 28, 2024 14:45
@cmbz cmbz mentioned this pull request Mar 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MellyGray MellyGray MellyGray approved these changes

Assignees
No one assigned
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GPortas @MellyGray