133 - Add publish dataset use case #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellyGray
added
Size: 3
g-saracca
previously approved these changes
Apr 1, 2024
|
Please, can you resolve the merge conflicst? @MellyGray |
…vascript into feature/133-add-publish-dataset-use-case
GPortas
reviewed
Apr 4, 2024
| @@ -32,4 +32,5 @@ export interface IDatasetsRepository { | |||
| datasetMetadataBlocks: MetadataBlock[], | |||
| collectionId: string | |||
| ): Promise<CreatedDatasetIdentifiers> | |||
| publishDataset(datasetId: number | string, versionUpdateType: 'major' | 'minor'): Promise<void> | |||
There was a problem hiding this comment.
Why not use versionUpdateType: VersionUpdateType instead of versionUpdateType: 'major' | 'minor'?
There was a problem hiding this comment.
I probably forgot. Thanks! I made the change
GPortas
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new use case to the module publishDataset to allow the user to publish a new version of a dataset using js-dataverse module.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Additional documentation: