Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

140 transform html to markdown for Collection description #145

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

ekraffmiller
Copy link
Contributor

What this PR does / why we need it:

Transforms html that may be in Collection description to markdown

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #

Special notes for your reviewer:

Suggestions on how to test this:

Create a new Collection in JSF, with a description that contains html. The getCollection useCase should return a collection that has a description with markdown.

Is there a release notes update needed for this change?:

Additional documentation:

@ekraffmiller ekraffmiller added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Apr 16, 2024
@MellyGray MellyGray self-assigned this Apr 17, 2024
test/testHelpers/collections/collectionHelper.ts Outdated Show resolved Hide resolved
test/testHelpers/collections/collectionHelper.ts Outdated Show resolved Hide resolved
test/unit/collections/CollectionsRepository.test.ts Outdated Show resolved Hide resolved
@MellyGray MellyGray assigned ekraffmiller and unassigned MellyGray Apr 17, 2024
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@MellyGray MellyGray removed their assignment Apr 18, 2024
@GPortas GPortas self-assigned this Apr 22, 2024
@GPortas GPortas merged commit 5b0b8cd into develop Apr 22, 2024
5 checks passed
@GPortas GPortas deleted the 140-transform-html-to-markdown branch April 22, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For getCollection useCase, transform html to markdown
3 participants