Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended create collection use case #162

Merged
merged 12 commits into from
Jul 26, 2024
Merged

Extended create collection use case #162

merged 12 commits into from
Jul 26, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Jul 19, 2024 •
edited
Loading

What this PR does / why we need it:

Extends CollectionDTO, used in createCollection use case, to include properties needed for the create collection page.

Also includes a new use case (getCollectionFacets) that will be needed for the information displayed on the create collection page.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

⚠️ Before merging this PR, change the environment variables in .env to point to the unstable image tag. It is currently pointing to 10633-create-collection-api-ext from ghcr to ensure the integration tests pass.

Suggestions on how to test this:

Is there a release notes update needed for this change?:

Additional documentation:

@GPortas GPortas marked this pull request as ready for review July 23, 2024 16:28
@GPortas GPortas added SPA: Collection Page GREI Re-arch GREI re-architecture-related Size: 3 A percentage of a sprint. 2.1 hours. and removed Size: 3 A percentage of a sprint. 2.1 hours. labels Jul 23, 2024
@g-saracca g-saracca self-assigned this Jul 23, 2024
g-saracca
g-saracca reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have some questions and suggestions (no need for changes).

src/collections/domain/dtos/CollectionDTO.ts Show resolved Hide resolved
docs/useCases.md Show resolved Hide resolved
src/collections/infra/repositories/CollectionsRepository.ts Outdated Show resolved Hide resolved
src/collections/infra/repositories/CollectionsRepository.ts Outdated Show resolved Hide resolved
src/collections/infra/repositories/transformers/collectionTransformers.ts Outdated Show resolved Hide resolved
@g-saracca g-saracca assigned GPortas and unassigned g-saracca Jul 24, 2024
@g-saracca g-saracca mentioned this pull request Jul 24, 2024
Closed
@GPortas GPortas mentioned this pull request Jul 26, 2024
Closed
@GPortas GPortas requested a review from g-saracca July 26, 2024 06:56
@GPortas GPortas assigned g-saracca and unassigned GPortas Jul 26, 2024
g-saracca
g-saracca previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking good! 🚀

@g-saracca g-saracca removed their assignment Jul 26, 2024
@ekraffmiller ekraffmiller self-assigned this Jul 26, 2024
@ekraffmiller ekraffmiller merged commit 3c135eb into develop Jul 26, 2024
5 checks passed
@cmbz cmbz mentioned this pull request Aug 1, 2024
Open
@GPortas GPortas added SPA.Q3.4 Create Collection page (Full version) Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-saracca g-saracca g-saracca left review comments

Assignees

@ekraffmiller ekraffmiller

Labels
GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q3.4 Create Collection page (Full version)
Projects
IQSS Dataverse Project
Status: Done 🧹
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evolve create collection use case to support all fields and sections
3 participants
@GPortas @g-saracca @ekraffmiller