Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new use case GetAllMetadataBlocks #172

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Aug 2, 2024

What this PR does / why we need it:

Adds new use case GetAllMetadataBlocks

Which issue(s) this PR closes:

Related Dataverse PRs:

None

Special notes for your reviewer:

None

Suggestions on how to test this:

Visual inspection and actions execution

@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related SPA: Create Collection Page labels Aug 2, 2024
@GPortas GPortas marked this pull request as ready for review August 6, 2024 09:14
@g-saracca g-saracca self-assigned this Aug 6, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍🏼 , approving 🚀

@g-saracca g-saracca removed their assignment Aug 6, 2024
@ekraffmiller ekraffmiller self-assigned this Aug 9, 2024
@ekraffmiller
Copy link
Contributor

I am getting an error in the integration test, even though I see it is passing in the Github Action. Is this due to something lacking in my local environment?

Screenshot 2024-08-09 at 1 37 43 PM

@GPortas
Copy link
Contributor Author

GPortas commented Aug 9, 2024

I am getting an error in the integration test, even though I see it is passing in the Github Action. Is this due to something lacking in my local environment?

Screenshot 2024-08-09 at 1 37 43 PM

@ekraffmiller I have encountered that error in the past, and in my case it was related to DNS resolution in my Docker environment. Could you please try restarting Docker on your local machine and running the tests again?

@ekraffmiller
Copy link
Contributor

I am getting an error in the integration test, even though I see it is passing in the Github Action. Is this due to something lacking in my local environment?
Screenshot 2024-08-09 at 1 37 43 PM

@ekraffmiller I have encountered that error in the past, and in my case it was related to DNS resolution in my Docker environment. Could you please try restarting Docker on your local machine and running the tests again?

That worked, thanks!

@ekraffmiller
Copy link
Contributor

Looks good! merging

@ekraffmiller ekraffmiller merged commit 69f4005 into develop Aug 9, 2024
5 checks passed
@GPortas GPortas added SPA.Q3.4 Create Collection page (Full version) Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Collection Page SPA.Q3.4 Create Collection page (Full version)
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Create use case for getting all metadata blocks defined in the installation
3 participants