Merge pull request #118 from IQSS/feature/115-dataset-summary-continued

115 - Dataset summary continued
IQSS · Jun 28, 2023 · 6663e29 · 6663e29
2 parents 389f634 + 0f4be02
commit 6663e29
Show file tree

Hide file tree

Showing 43 changed files with 843 additions and 535 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -84,6 +84,13 @@ jobs:
           path-to-lcov: './merged-coverage/lcov.info'
           github-token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Upload Cypress screenshots
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: cypress-screenshots
+          path: ./cypress/screenshots
+
   interaction-and-accessibility:
     runs-on: ubuntu-latest
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -94,7 +94,7 @@
   "devDependencies": {
     "@csstools/postcss-cascade-layers": "^3.0.1",
     "@cypress/code-coverage": "^3.10.4",
-    "@IQSS/dataverse-client-javascript": "2.0.0-pr60.bb367b6",
+    "@IQSS/dataverse-client-javascript": "2.0.0-pr67.5dfc70a",
     "@storybook/addon-a11y": "^7.0.2",
     "@storybook/addon-essentials": "^7.0.2",
     "@storybook/addon-interactions": "^7.0.2",

diff --git a/packages/design-system/tests/component/navbar/Navbar.spec.tsx b/packages/design-system/tests/component/navbar/Navbar.spec.tsx
@@ -10,7 +10,7 @@ describe('Navbar component', () => {
   it('renders the brand logo and title', () => {
     cy.mount(<Navbar brand={brand} />)
 
-    cy.findByRole('img', { name: 'Brand Logo Image' }).should('exist')
+    cy.findByAltText('Brand Logo Image').should('exist')
     cy.findByText('Brand Title').should('exist')
   })
 

diff --git a/public/locales/en/citation.json b/public/locales/en/citation.json
@@ -65,7 +65,8 @@
       },
       "datasetContact": {
         "name": "Point of Contact",
-        "description": "The entity, e.g. a person or organization, that users of the Dataset can contact with questions"
+        "description": "The entity, e.g. a person or organization, that users of the Dataset can contact with questions",
+        "tip": "Use email button above to contact."
       },
       "datasetContactName": {
         "name": "Name",

diff --git a/public/locales/en/customARCS.json b/public/locales/en/customARCS.json
diff --git a/public/locales/en/customCHIA.json b/public/locales/en/customCHIA.json
diff --git a/public/locales/en/customDigaai.json b/public/locales/en/customDigaai.json
diff --git a/public/locales/en/customGSD.json b/public/locales/en/customGSD.json
diff --git a/public/locales/en/customMRA.json b/public/locales/en/customMRA.json
diff --git a/public/locales/en/customPSI.json b/public/locales/en/customPSI.json
diff --git a/public/locales/en/customPSRI.json b/public/locales/en/customPSRI.json
diff --git a/public/locales/en/custom_hbgdki.json b/public/locales/en/custom_hbgdki.json