Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all required fields to the Create Dataset Form #252

Closed
GPortas opened this issue Dec 6, 2023 · 11 comments
Closed

Add all required fields to the Create Dataset Form #252

GPortas opened this issue Dec 6, 2023 · 11 comments
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA: Create Dataset Form UI Tasks related to the user interface (UI) or frontend development Waiting

Comments

@GPortas
Copy link
Contributor

GPortas commented Dec 6, 2023

Overview of the Feature Request

Add all required fields to the Create Dataset Form. This is only the UI, so no API connected.

requiredfields

These changes will be added to the boilerplate created on #231, so we need to wait for PR #251 to be accepted.

What kind of user is the feature intended for?

All of them

What inspired the request?

What existing behavior do you want changed?

None

Any brand new behavior do you want to add to Dataverse?

Include the required fields to the Create Dataset Form

Any open or closed issues related to this feature request?

@GPortas GPortas added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows UI Tasks related to the user interface (UI) or frontend development labels Dec 6, 2023
@M27Mangan M27Mangan self-assigned this Dec 6, 2023
@GPortas
Copy link
Contributor Author

GPortas commented Jan 2, 2024

Should this issue be tagged with the waiting tag until the create dataset boilerplate PR is closed? I think the changes to be developed in this issue depend on the page boilerplate resulting from the PR.

@pdurbin I see you moved the issue to in progress, I'm not sure if I'm missing something.

@M27Mangan

@GPortas
Copy link
Contributor Author

GPortas commented Jan 2, 2024

As discussed in standup.

Moved the issue back to This Sprint column and added the waiting tag due to dependency with #251

@pdurbin
Copy link
Member

pdurbin commented Jan 5, 2024

Weird, I don't remember moving it but a lot of issues got moved in the transition from project 2 to 34. 😅

@M27Mangan M27Mangan self-assigned this Jan 12, 2024
@M27Mangan
Copy link

@gporta, @MellyGray, @ekraffmiller Who should I talk to regarding the dynamic creation of Form Fields, and what rules govern when certain fields are visible?

@MellyGray
Copy link
Contributor

@M27Mangan, we discussed this last Monday during the post-standup meeting. I believe @GPortas had an approach for this. There are some config files that need to be read to display the form fields, and these would be obtained via API

@GPortas
Copy link
Contributor Author

GPortas commented Jan 15, 2024

As stated here #252 (comment), this issue has a "Waiting" tag. Could you please start another issue that doesn't have the Waiting tag? @M27Mangan

@GPortas
Copy link
Contributor Author

GPortas commented Jan 17, 2024

@M27Mangan

I have moved this issue back to sprint ready, as its implementation should be wait for #251 to be merged.

I have created a new analysis issue, to include in this new sprint, considering your interest in yesterday's standup in analyzing the implementation of the form fields: #282. We don't need to wait for the analysis issue, as it does not require code changes.

I have sized the issue with a 10, but feel free to resize it as you consider.

@MellyGray
Copy link
Contributor

I'm removing the "Waiting" tag, as #251 is now in "Ready for QA", and we believe it's unlikely that the code will change at this stage on the board. It seems better to potentially have some changes from QA and need to pull from that branch, rather than continue to block the development of this feature

Also we've done this in the past with other issues with the Waiting tag, we removed it once the blocking issue was in Ready for QA

@GPortas
Copy link
Contributor Author

GPortas commented Jan 31, 2024

Deprioritized and moved back to SPA backlog in order to focus on File Page issues.

We will prioritize issues for "Create Dataset" once we finalize the File Page work.

@cmbz

@GPortas
Copy link
Contributor Author

GPortas commented Mar 4, 2024

Waiting for: #316

@GPortas GPortas added the Waiting label Mar 4, 2024
@MellyGray
Copy link
Contributor

Closing this issue because the required fields were already added in the scope of

We'll continue working on the rest of the fields in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA: Create Dataset Form UI Tasks related to the user interface (UI) or frontend development Waiting
Projects
None yet
Development

No branches or pull requests

4 participants