Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/358 add unpublished label to collections page #372

Merged

Conversation

ekraffmiller
Copy link
Contributor

What this PR does / why we need it:

Adds an 'Unpublished' label to the Collections page, if the collection has not been published

Which issue(s) this PR closes:

Special notes for your reviewer:

The flag, isReleased, is not yet available from the javascript library, waiting for this: IQSS/dataverse-client-javascript#139

Suggestions on how to test this:

Look at the UnpublishedCollection Story, which shows the label: http://localhost:6006/?path=/story/sections-collection-page-collectioninfo--unpublished

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

This is what the label looks like in JSF:
Screenshot 2024-04-17 at 9 24 02 AM

Is there a release notes update needed for this change?:

no

Additional documentation:

@ekraffmiller ekraffmiller marked this pull request as ready for review April 17, 2024 14:11
@ekraffmiller ekraffmiller added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Apr 17, 2024
@g-saracca g-saracca self-assigned this Apr 17, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, leave some comments just to improve layout.

src/sections/collection/CollectionInfo.tsx Outdated Show resolved Hide resolved
src/sections/collection/Collection.module.scss Outdated Show resolved Hide resolved
@g-saracca g-saracca assigned ekraffmiller and unassigned g-saracca Apr 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.326% (+0.002%) from 97.324%
when pulling a510c8f on feature/358-add-unpublished-label-to-collections-page
into 6849096 on develop.

Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GPortas GPortas self-assigned this Apr 22, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created a test collection and it doesn't show the Unpublished label. It is shown in JSF.

SPA:

SPAlabel

JSF:

JSFlabel

maybe I'm missing something? @ekraffmiller

@GPortas GPortas assigned ekraffmiller and unassigned ekraffmiller Apr 22, 2024
@GPortas
Copy link
Contributor

GPortas commented Apr 22, 2024

Oh, nevermind. I see the isReleased value is hardcoded to false. I am going to hardcode it to true and see what happens. @ekraffmiller

EDIT: Looks good, approving:

showingunpublished

@GPortas GPortas merged commit b17114a into develop Apr 22, 2024
14 checks passed
@GPortas GPortas deleted the feature/358-add-unpublished-label-to-collections-page branch April 22, 2024 13:21
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…el-to-collections-page

Feature/358 add unpublished label to collections page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Unpublished' label to Collections page
4 participants