387 Fix Race Condition in e2e tests #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
pm.GREI-d-2.7.1
g-saracca
previously approved these changes
May 13, 2024
tests/e2e-integration/integration/files/FileJSDataverseRepository.spec.ts
Outdated
Show resolved
Hide resolved
g-saracca
approved these changes
May 15, 2024
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
387 Fix Race Condition in e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Then e2e tests were sometimes failing because the destroyAll() method does not always clear the solr index correctly. Rather than always calling destroyAll(), the tests were updated to create datasets in separate collections, where necessary, so that dataset counts are not affected by the order of tests.
Which issue(s) this PR closes:
Closes #387
Special notes for your reviewer:
Suggestions on how to test this:
Run the e2e test locally
npm run test:e2eCheck that then e2e test in Github action succeeds
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: