Feature/446 file card #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
SPA: Collection Page
GREI Re-arch
g-saracca
requested changes
Aug 6, 2024
src/sections/collection/datasets-list/file-card/FileCardHeader.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/datasets-list/file-card/FileCardInfo.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/datasets-list/file-card/FileCardInfo.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/datasets-list/file-card/FileCard.module.scss
Outdated
Show resolved
Hide resolved
src/sections/collection/datasets-list/file-card/FileCard.module.scss
Outdated
Show resolved
Hide resolved
src/sections/collection/datasets-list/file-card/FileCard.module.scss
Outdated
Show resolved
Hide resolved
|
Thanks @GermanSaracca, I made the requested changes, I just have a small question about the html change. |
g-saracca
requested changes
Aug 8, 2024
src/sections/collection/datasets-list/file-card/FileCard.module.scss
Outdated
Show resolved
Hide resolved
GPortas
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FIleCard component for the search results on the Collection page
Which issue(s) this PR closes:
Closes #446
Special notes for your reviewer:
I created a new component FileCardIcon, to manage the styles needed for the FileCard, I thought this was simpler than sharing the FileCard component used in FilePreview, but open for feedback on that :)
Suggestions on how to test this:
npm run storybook
Review the FileCard Stories http://localhost:6006/?path=/story/sections-collection-page-filecard--default
Upload files into Dataverse and compare the FileCard to the UI in the JSF version of the Collection page.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
JSF Version of FileCards example:
Is there a release notes update needed for this change?:
No
Additional documentation: