Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

437 - Collection page url #453

Merged
merged 7 commits into from
Aug 21, 2024
Merged

437 - Collection page url #453

merged 7 commits into from
Aug 21, 2024

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:
Change Collection page url from
https://beta.dataverse.org/spa/collections?id=[collectionIdentifier].
to
https://beta.dataverse.org/spa/collections/[collectionIdentifier]

Which issue(s) this PR closes:

Closes #437

Special notes for your reviewer:
N/A

Suggestions on how to test this:
Create collections and navigate to them trough direct url and trough breadcrumbs.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A

Is there a release notes update needed for this change?:
N/A

Additional documentation:
N/A

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page GREI Re-arch GREI re-architecture-related FY25 Sprint 3 FY25 Sprint 3 labels Aug 8, 2024
@coveralls
Copy link

coveralls commented Aug 8, 2024

Coverage Status

coverage: 97.922% (-0.02%) from 97.939%
when pulling bebc57d on feat/437-collection-page-url
into f66b503 on develop.

@g-saracca g-saracca changed the title Feat/437 collection page url 437 - Collection page url Aug 8, 2024
@ekraffmiller ekraffmiller self-assigned this Aug 12, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just have one small comment

@g-saracca g-saracca removed their assignment Aug 13, 2024
ekraffmiller
ekraffmiller previously approved these changes Aug 13, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved!

@ekraffmiller ekraffmiller removed their assignment Aug 13, 2024
@GPortas GPortas merged commit 5832262 into develop Aug 21, 2024
10 of 14 checks passed
@GPortas GPortas deleted the feat/437-collection-page-url branch August 21, 2024 09:34
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 3 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 3 FY25 Sprint 3 GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q3 Not related to any specific Q3 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Prettier Url on Collection Page
4 participants