Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

485 create dataset url #493

Merged
merged 3 commits into from
Sep 18, 2024
Merged

485 create dataset url #493

merged 3 commits into from
Sep 18, 2024

Conversation

ChengShi-1
Copy link
Contributor

What this PR does / why we need it:

We decided to modify the URL path for the 'create dataset' page to maintain consistency with the 'create collection' structure.

The changes are as follows:
Old path: /spa/datasets/create?collectionId=[collectionId]
New path: /spa/datasets/[collectionId]/create

Which issue(s) this PR closes:

Special notes for your reviewer:

Originally, we have /spa/datasets/create could be accessible, but after updating, it wouldn't work.

Suggestions on how to test this:

  1. Click the header "Add Data" => "New Dataset", check if the url is correct
  2. On the main page, click the button"+ Add Data" => "New Dataset", check if the url is correct

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

The Developer_Guide doc changes, because this change relates to a testing example shown on the developer guide.

@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Dataset Form GREI Re-arch GREI re-architecture-related FY25 Sprint 6 FY25 Sprint 6 labels Sep 17, 2024
@ChengShi-1 ChengShi-1 linked an issue Sep 17, 2024 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

coverage: 97.397% (+0.001%) from 97.396%
when pulling c9a36cd on 485-create-dataset-url
into 4dc5ff1 on develop.

@ChengShi-1 ChengShi-1 marked this pull request as ready for review September 17, 2024 18:35
@g-saracca g-saracca self-assigned this Sep 17, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks more than good! Approving

@g-saracca g-saracca removed their assignment Sep 18, 2024
@ekraffmiller
Copy link
Contributor

looks good! merging

@ekraffmiller ekraffmiller merged commit c6c5144 into develop Sep 18, 2024
18 checks passed
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 6 FY25 Sprint 6 GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Dataset Form SPA.Q3 Not related to any specific Q3 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Create Dataset URL
5 participants