Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

126 add error handling mechanism to the UI #518

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
+218 −12
Open

126 add error handling mechanism to the UI #518

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
709b8fc
feat: error handling UI page
ChengShi-1 Oct 1, 2024
545bb9b
test: useErrorLogger hook test
ChengShi-1 Oct 2, 2024
3186877
chore: useErrorLogger hook test
ChengShi-1 Oct 2, 2024
de6b9b7
bug: fix some bugs in useErrorLogger hook test
ChengShi-1 Oct 3, 2024
b2159f4
feat: add errorElement to the children routes for adding header and f…
ChengShi-1 Oct 4, 2024
dd21944
feat: add text variables to the page
ChengShi-1 Oct 4, 2024
6d39627
Merge branch 'develop' into 126-add-error-handling-mechanism-to-the-ui
ChengShi-1 Oct 4, 2024
1bc573e
fix: adjust min-height of css as a dynamic variable
ChengShi-1 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sections/error-page/ErrorPage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
flex-direction: column;
align-items: center;
justify-content: center;
min-height: $main-container-available-height;
min-height: var(--error-min-height);
}

.middle-search-cta-wrapper {
Expand Down
5 changes: 5 additions & 0 deletions src/sections/error-page/ErrorPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export function ErrorPage() {
useErrorLogger(error)
const theme = useTheme()

const header = document.querySelector('nav')
const footer = document.querySelector('footer')
const newMinHeight = header && footer ? '$main-container-available-height' : '100vh'
document.documentElement.style.setProperty('--error-min-height', newMinHeight)

Copy link
Contributor

@g-saracca g-saracca Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid running natives javascript dom selectors to find elements by their tag name or even by a class name, these might change and might not even be the only ones you find.

Take a look at this, is from my lazy imports PR, see this tsx file and this scss one.

So then you only need to pass that prop to the ErrorPage on the root layout path object.


  {
    path: '/',
    element: <Layout />,
    errorElement: <ErrorPage fullViewport />,
    children: [
    ...rest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll follow the example. Thank you!

return (
<section className={styles['section-wrapper']}>
<div className={styles['middle-search-cta-wrapper']}>
Expand Down
Loading