Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPCONFIG: move JvmSettings to SPI (was: allow to retrieve all values used for a placeholder scoped setting) #10000

Open
poikilotherm opened this issue Oct 11, 2023 · 0 comments
Assignees
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Component: Containers Anything related to cloudy Dataverse, shipped in containers.

Comments

@poikilotherm
Copy link
Contributor

poikilotherm commented Oct 11, 2023

Overview of the Feature Request
We need to move the JVM settings stuff into the SPI package, so people writing exporters and other modular stuff can reuse the configuration lookup things in their modules.

~~For JVM options that contain placeholders, we usually provide the substitution value in some way to lookup the configuration value.

It is currently not possible to retrieve a list of used values for a placeholder, determined from settings provided by a sysadmin.~~

It might no longer be necessary to add this, as we seem to come to a consensus that it's OK to have a list of things to look for. See the new PID settings.

What kind of user is the feature intended for?
Sysadmin

What inspired the request?
This is currently necessary for storage configuration (#9998), but is likely to be used in the future, when we enable multiple instances of PID providers (#3623). No longer true. One of the inspirations to move these things is now #10048

What existing behavior do you want changed?
See above.

Any brand new behavior do you want to add to Dataverse?
Nope

Any open or closed issues related to this feature request?
#7000 #3623 #9998

@poikilotherm poikilotherm self-assigned this Oct 11, 2023
@poikilotherm poikilotherm added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Oct 11, 2023
@pdurbin pdurbin added the Component: Containers Anything related to cloudy Dataverse, shipped in containers. label Oct 19, 2023
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 8, 2023
With this package, we will move most of the logic for lookups of JVM options to this package.
Future plugins but also the main codebase will benefit from all the logic in one place.
@poikilotherm poikilotherm changed the title MPCONFIG: retrieve all values used for a placeholder scoped setting MPCONFIG: move JvmSettings to SPI (was: allow to retrieve all values used for a placeholder scoped setting) Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Component: Containers Anything related to cloudy Dataverse, shipped in containers.
Projects
Status: No status
Development

No branches or pull requests

2 participants