Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try-with-resources to close JsonReader "report = Json.createReader(reader).readObject();" in method addUsageMetricsFromSushiReport(...) and to close JsonReader "report = Json.createReader(reader).readObject();" in method ddUsageMetricsFromSushiReportAll(...) and to close JsonReader "JsonObject report = Json.createReader(connection.getInputStream()).readObject();" in method updateCitationsForDataset(...) in MakeDataCountApi.java #10056

Closed
rtreacy opened this issue Oct 26, 2023 · 5 comments · Fixed by #10062
Milestone

Comments

@rtreacy
Copy link
Contributor

rtreacy commented Oct 26, 2023

No description provided.

@bencomp
Copy link
Contributor

bencomp commented Oct 27, 2023

Oh, I missed a few of these in #9980! (#10054 is very similar)

Are you working on this already?

@qqmyers
Copy link
Member

qqmyers commented Oct 27, 2023

In general, issues still in the Dataverse_Global_Backlog board shouldn't be being worked on by anyone in the core team, so unless there's an assignment or chatter in the issue, I think you can consider it open.

@pdurbin
Copy link
Member

pdurbin commented Oct 27, 2023

@rtreacy
Copy link
Contributor Author

rtreacy commented Oct 27, 2023

Every one of these you work on, let us know. We'll get them into ready for review and Jim can push them across the line. This is really critical IMHO

@bencomp
Copy link
Contributor

bencomp commented Oct 27, 2023

I just marked #10062 ready for review 😃

@pdurbin pdurbin added this to the 6.1 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants