Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails sent to Dataset Owners from "Guestbook at Request Access" missing key information and are hard to read due to Q/As being in random order and no formatting between #10581

Closed
mdmADA opened this issue May 23, 2024 · 5 comments · Fixed by #10653
Assignees
Labels
Feature: Guestbook Feature: Notifications FY24 Sprint 26 FY24 Sprint 26 Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Milestone

Comments

@mdmADA
Copy link
Contributor

mdmADA commented May 23, 2024


Description:

Note that the email issues detailed below are costing ADA a lot of additional time and resources, so it is a critical issue for ADA's day-to-day operations.

The email that is sent to dataset/owners has the following issues:

1. The subject line is the same for every request for the same dataset.

  • If there are many requests, this makes it impossible to pick out unique requests per user when looking at the email inbox and/or a ticketing system where tickets are generated with the email subject.
  • The access/ticket manager has to open each email to see who requested it. [Dataverse sends the emails from ADA's email address so the emails/tickets all have the same "from" so that doesn't assist in unique identification].

Now, in dv 6.2, the email subject is:
ADA Dataverse : Access has been requested for a restricted file in dataset "dataset title"

If there are 100 emails for dataset x then there will be 100 emails with the same subject line with no uniquely identifying information.

ADA's previous Dataverse installation email subject sent to Dataset owner/contact:
ADA Dataverse: “Firstname Lastname (@xxxxxx)" requested access to dataset “dataset title"

If there are 100 emails from 100 different users requesting access, there are 100 unique email subject lines, so the access/ticket manager can see them at a glance without having to open each ticket/email.

ADA is requesting the email subject be changed to (where xxxx is the root dataverse):
xxxx Dataverse: “Firstname Lastname (@xxxxxx)" requested access to dataset "dataset title"

2. The user details in the email should include:

Name:
Email:
Institution:
Position:
authenticateduserid: numeric_database_id
useridentifier: @useridentifier

3. The Questions from the user's guestbook response are not in the same order as the guestbook itself and are random order from email to emai.

The Q/A pairs should be written to the email in the displayorder as specified for the guestbook.

4. There is no spacing between the Q/A pairs so it is almost impossible to read for long and more complex answers.

One or 2 blank lines between each Q/A pair is necessary for readability.

NOTE: 3 and 4 also occur for the email sent to the user who requested access. Not sure if a new bug report is required for that?


What steps does it take to reproduce the issue?

  1. Either you or someone else go to a dataset that has:
  • "guestbookAtRequestAccess" flag set to true
  • restricted files
  • assigned guestbook with custom questions
  • the dataset owner/contact is set such that you will receive the request access email sent to the dataset owner/contact to alert them to the request
  1. Click "Request Access"

  2. Enter answers to the custom questions + Click "Request" or "Accept" in the popup

  3. You will receive the email that was generated by the Access Request


When does this issue occur?

When emails are generated for the dataset owner/contact in the "Guestbook at Request Access" functionality.
(The questions out of order also occurs in email sent to the requester).


Which page(s) does it occur on?

Dataset.xhtml, file.xhtml, anywhere where there is a "guestbook at request access" email generated.


What happens?
see description above


To whom does it occur (all users, curators, superusers)?
Dataset owners/contacts and/or access/ticket managers who receive and mange the access requests with email and.or a ticketing system.

Questions out of order also occurs in the requester's email.


What did you expect to happen?
See description at top.


Which version of Dataverse are you using?
6.2


Any related open or closed issues to this bug report?
No.


Including @stevenmce for any further comments/information.

@mdmADA mdmADA added the Type: Bug a defect label May 23, 2024
@pdurbin pdurbin changed the title Emails sent to Dataset Owners from "Guestbook at Request Acccess" missing key information and are hard to read Emails sent to Dataset Owners from "Guestbook at Request Access" missing key information and are hard to read May 23, 2024
@mdmADA mdmADA changed the title Emails sent to Dataset Owners from "Guestbook at Request Access" missing key information and are hard to read Emails sent to Dataset Owners from "Guestbook at Request Access" missing key information and are hard to read due to Q/As being in random order and no formatting between May 28, 2024
@stevenmce
Copy link

@pdurbin can you advise if this is something that can be worked on in the short term? This is a priority for ADA.

@pdurbin
Copy link
Member

pdurbin commented May 30, 2024

Let's ask @cmbz and @scolapasta

@cmbz cmbz added this to the 6.3 milestone May 30, 2024
@cmbz cmbz modified the milestone: 6.3 Jun 20, 2024
@cmbz cmbz added FY24 Sprint 26 FY24 Sprint 26 Size: 10 A percentage of a sprint. 7 hours. labels Jun 20, 2024
@sekmiller sekmiller self-assigned this Jun 21, 2024
sekmiller added a commit that referenced this issue Jun 24, 2024
sekmiller added a commit that referenced this issue Jun 25, 2024
stevenwinship pushed a commit that referenced this issue Jun 25, 2024
* #10581 fix subject line of request access email

* #10581 add sorter

* #10581 addl user info for request email

* #10581 add break between custom Q responses

* #10581 remove orderby
@mdmADA
Copy link
Contributor Author

mdmADA commented Jun 25, 2024

In re-reading this issue (that I created), please retain the guestbookresponse_id in the email (and add in the other id's requested).

@sekmiller
Copy link
Contributor

We did not remove the guestbookresponse_id from the email.

@mdmADA
Copy link
Contributor Author

mdmADA commented Jun 26, 2024

Great - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Guestbook Feature: Notifications FY24 Sprint 26 FY24 Sprint 26 Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants