Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataverses/{id}/metadatablocks API returned dataset field types #10637

Closed
GPortas opened this issue Jun 18, 2024 · 0 comments · Fixed by #10642
Closed

Fix dataverses/{id}/metadatablocks API returned dataset field types #10637

GPortas opened this issue Jun 18, 2024 · 0 comments · Fixed by #10642
Labels
GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q3 Not related to any specific Q3 feature SPA These changes are required for the Dataverse SPA Type: Bug a defect User Role: API User Makes use of APIs
Milestone
6.3

Comments

@GPortas
Copy link
Contributor

GPortas commented Jun 18, 2024 •
edited
Loading

Overview of the Feature Request

The fields returned for each metadata block when returnDatasetTypes query parameter is true are incorrect because the display condition based on dataset field types input levels is not working as expected.

What kind of user is the feature intended for?
API User

What inspired the request?

  • Working on SPA create collection form
  • Working on SPA edit dataset form

What existing behavior do you want changed?
Current dataverses/{id}/metadatablocks API endpoint returned dataset field types

Any open or closed issues related to this feature request?
@GPortas GPortas added Type: Feature a feature request User Role: API User Makes use of APIs SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture labels Jun 18, 2024
@GPortas GPortas mentioned this issue Jun 19, 2024
Merged
@GPortas GPortas changed the title Modify the dataverses/{id}/metadatablocks API endpoint to return only the included dataset field types, specifying whether they are required or not Fix dataverses/{id}/metadatablocks API returned dataset field types Jun 19, 2024
@GPortas GPortas added Type: Bug a defect and removed Type: Feature a feature request labels Jun 19, 2024
GPortas added a commit that referenced this issue Jun 19, 2024
@GPortas
Added: release notes for #10637
1246d7c
stevenwinship pushed a commit that referenced this issue Jul 2, 2024
@GPortas
Fix metadata field type display condition in dataverses/{id}/metadata…
b42222f 
…blocks API endpoint (#10642)

* Fixed: metadata field type display condition in dataverses/{id}/metadatablocks

* Changed: json object builder instantiation

* Added: extended test coverage for testUpdateInputLevels and testFeatureDataverse

* Added: release notes for #10637

* Fixed: JsonPrinter metadata blocks dataset field type isRequired logic

* Refactor: simpler conditions in jsonPrinter

* Refactor: reordered condition in jsonPrinter

* Fixed: displayCondition in jsonPrinter
@pdurbin pdurbin added this to the 6.3 milestone Jul 2, 2024
pdurbin added a commit that referenced this issue Jul 2, 2024
@pdurbin
incorporate #10637 into release note #10646
214d3b2
pdurbin added a commit that referenced this issue Jul 2, 2024
@pdurbin
no need to mention #10637 and #10642 as they were pre-release #10646
ffa616f
stevenwinship pushed a commit that referenced this issue Jul 2, 2024
@jp-tosca @landreev
@qqmyers @sekmiller @pdurbin
6.3 Release Notes (#10662)
ecb5e94 
* Initial changes

* Update with 4th lvl H

* Table of contet change

* MD format test

* External voc info update

* Update 1:04

* First version for PR

* a few quick changes to the upgrade instruction #10646

* Update 6.3-release-notes.md

* keywordTermURI heading #10646

* removed reExportAll from the upgrade instruction; it's only needed if they
choose to perform the optional step of migrating some metadata fields; and it
is already mentioned in the instruction on how to do that. #10646

* simplified the jvm options part of the payara upgrade instruction #10646

* moved payara upgrade into the main upgrade instruction #10646

* typos #10646

* added the Solr upgrade instruction #10646

* cosmetic #10646

* cosmetic #10646

* Deleted the solr upgrade note. #10646

* Initial changes

* #10646 add note about file access request email update

* Add issue number test

* add featured collection link

* Test issue link

* Batch of issues #

* Bug fixes issues no

* #10646 add issue link

* normalize line endings #10646

* various improvments #10646

* reorder #10646

* add Contributor Guide to 6.3 release notes #10646

* incorporate #10637 into release note #10646

* Update 6.3-release-notes.md

* Make Hidden HTML fields one more element in the ext. vocab updates

* Removing snippets

* small tweaks to upgrade instructions #10646

* no need to mention #10637 and #10642 as they were pre-release #10646

* s/safe/supported/ and remove dupe #10646

---------

Co-authored-by: Leonid Andreev <leonid@hmdc.harvard.edu>
Co-authored-by: qqmyers <qqmyers@hotmail.com>
Co-authored-by: Stephen Kraffmiller <skraffmiller@hmdc.harvard.edu>
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@pdurbin pdurbin mentioned this issue Aug 12, 2024
Open
@GPortas GPortas added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA.Q3 Not related to any specific Q3 feature Size: 10 A percentage of a sprint. 7 hours. Original size: 10 and removed Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q3 Not related to any specific Q3 feature SPA These changes are required for the Dataverse SPA Type: Bug a defect User Role: API User Makes use of APIs
Projects
IQSS Dataverse Project
Status: No status
Milestone
6.3
2 participants
@pdurbin @GPortas