Saved Search - do not link to search or link to files

[scolapasta]

Since we currently don't support linking to files (and may not want to), we should not create any links for files.

Also, we can remove the files as something for the filter query when saving.

[pdurbin]

It sounds like this ticket is about two things:

Thing 1: If there's a hit on a file, don't ever link the parent dataset.

This is easy enough. It's just a backend change to skip any hits for files when making links. I pushed this change in a new branch in this commit: fee47b7

@scolapasta please let me know if you'd like this to be merged in.

Thing 2: After a user has done a search, explain that even though files matches the search (assuming they did), the "saved search" will not include datasets where files matched. This is much more of a usability issue since I think the user will expect that if a search matched something, it will be linked. After all, we're re-using the normal search interface to construct saved searches. Here's a screenshot:

I guess we'll need to change the pop up to explain this. I'm not sure what this should look like...

Passing to @scolapasta for comment. I've also asked @mheppler for opinions.

[pdurbin]

From chatting with @scolapasta it sounds like the backend change at fee47b7 is the main one he's interested in (not linking datasets of files that match). We can sort out the usability issue later.

[scolapasta]

While there is still work to be done on this on the usability side, since this is a super user feature, it is OK for 4.0.

[suenjedt]

Test result:

• Successfully linked the search results. DV and datasets were included; files were not shown in the destination collection/dataverse
• However, UX/UI wise I did not see any warning that "files" are not linked.
  @kcondon: I understand that it is possibly implemented yet - correct?

[pdurbin]

UX/UI wise I did not see any warning that "files" are not linked

This is expected. @mheppler didn't want this:

I suggest that we use #1890 to improve the UX/UI.

[mheppler]

@suenjedt @pdurbin @kcondon -- if the functionality is as promised, I say ship it for 4.0. As pointed out, we have a 4.0.1 issue tracking UI improvements, before this feature is expanded beyond super-user admins.

And yes, we shouldn't be using great big, red "error/danger" message blocks (as shown above) for help/warning message text. We use those for when something breaks or is invalid. (If we had a robust design guide, that would be outlined in it.)

[suenjedt]

For me (as a newbie to this endeavor), the functionality worked as expected.
@mheppler I agree, that a big "red" block might be too much. I noticed you use blue for tips etc. If wished, one could maybe sneak it in as a tip. But please feel free to ignore my musings here.

[scolapasta]

Yesterday we established using the warning orange block for something similar. (Not getting what you expected )

[suenjedt]

Expected was: I search and find DV, datasets and underlying files, I save/link the search in a (destination) dataverse. I find the searched items (DV, dataset) in the destination dataverse.
Conclusion: all this worked

[All the other musing above were about the remaining UX/UI challenge]