Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style: meaningful strings should be constants, but aren't #2724

Closed
bencomp opened this issue Nov 5, 2015 · 1 comment
Closed

Code style: meaningful strings should be constants, but aren't #2724

bencomp opened this issue Nov 5, 2015 · 1 comment
Milestone
4.7 - Customizati...

Comments

@bencomp
Copy link
Contributor

bencomp commented Nov 5, 2015

As @pdurbin notes in #2720 (comment), the file extension ".tab" is hardcoded in many places (and therefore changing it is non-trivial).
There are many more important strings in the Dataverse code that suffer from this. For example, URI paths and query parameters, special metadata block names ("citation") with property names ("title") and many more.

Special strings should be defined as public constants and they should be used throughout the code.
@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@mheppler mheppler added Component: Documentation Component: Code Infrastructure formerly "Feature: Code Infrastructure" labels Jan 28, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin pdurbin self-assigned this Jun 9, 2017
@pdurbin pdurbin mentioned this issue Jun 9, 2017
Closed
@pdurbin pdurbin removed Component: Code Infrastructure formerly "Feature: Code Infrastructure" Status: Triaged labels Jun 13, 2017
pdurbin added a commit that referenced this issue Jun 20, 2017
@pdurbin
improve coding style page in dev guide #3418 #2724 #2644 #2575 #2574
6535d9d
@pdurbin
Copy link
Member

pdurbin commented Jun 20, 2017

I implemented this in 6535d9d and am closing this issue in favor of #3418.

@pdurbin pdurbin closed this as completed Jun 20, 2017
@pdurbin pdurbin removed their assignment Jun 20, 2017
This was referenced Jun 20, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7 - Customization and Community Rel...
Development

No branches or pull requests
5 participants
@pdurbin @mercecrosas @mheppler @bencomp @scolapasta